Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual SNMP trap enabling #212

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Conversation

deligatedgeek
Copy link
Contributor

Added a template for trigger.conf and 4 new parameters for freeradius class

  • $snmp_traps_enable - Whether to actual trap and not just echo commands
  • $snmp_traps_community - The SNMP community string/shared secret of the trap destination
  • $snmp_traps_dest - The IP address of the trap destination
  • $snmp_traps - And array of trap names, if empty it is populated with all trap names, if a list of traps is supplied then those are enabled.

There are no dependencies between parameters to allow full configuration of file and checking before enabling traps

@deligatedgeek
Copy link
Contributor Author

@nward A clean start on the trigger.conf trap configuration.
Not sure why this is failing tests, but the code does work when testing in my environment

@deligatedgeek
Copy link
Contributor Author

Does anyone why know why checks which are seeming unrelated to my changes are failing, I forked the last commit that passed so I don't know what's going on.

@deligatedgeek
Copy link
Contributor Author

Resolves #187

@djjudas21
Copy link
Owner

The tests are also failing in the same way on the latest commit in main, so this isn't you, this is the tests. Looks like some incorrectly specified test data.

Are you happy that this change is complete, and working?

@deligatedgeek
Copy link
Contributor Author

@djjudas21 Im happy this is completed and working.

@djjudas21
Copy link
Owner

I've hada quick look, and I'm happy to merge if you can add some basic documentation to README.md to include the new parameters, the expected values, etc. Thanks.

@nward is there anything you want to add before we merge?

@djjudas21 djjudas21 merged commit 0ddb4d1 into djjudas21:main Mar 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants