Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing 'n' fixes #94

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

mumbleskates
Copy link
Contributor

Mostly some spit & polish changes:

  • run the build ci step in the master branch
  • run cargo test --benches for sanity in the build step, with dev mode debug assertions
    • this catches problems like some unaligned pointer reads & an arithmetic panic in the rng implementation of one of the test data types
  • general organization in Cargo.toml, some alphabetization and grouping features together a bit to make things simpler
  • i also propose here to disable wiring from the default bench set after some discoveries i made chasing down what was going on with the aforementioned unaligned pointer read (which is to my knowledge already UB since it's done through a reference); in trying to whip up a test case for that i found a logic bug that could be an even more serious problem.

@djkoloski djkoloski merged commit 1193c7f into djkoloski:master Jan 15, 2025
1 check passed
@djkoloski
Copy link
Owner

louaykamel/wiring#3 is the wiring issue for posterity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants