Skip to content

Commit

Permalink
Remove other user-defined model unique naming
Browse files Browse the repository at this point in the history
Added to TODO list in Pyomo#3345
  • Loading branch information
djlaky committed Aug 13, 2024
1 parent 57a8a81 commit 0b08aef
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions pyomo/contrib/doe/doe.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,10 +433,12 @@ def compute_FIM(self, model=None, method="sequential"):
).clone()
model = self.compute_FIM_model
else:
doe_block = pyo.Block()
doe_block_name = unique_component_name(model, "design_of_experiments_block")
model.add_component(doe_block_name, doe_block)
self.compute_FIM_model = model
# TODO: Add safe naming when a model is passed by the user.
# doe_block = pyo.Block()
# doe_block_name = unique_component_name(model, "design_of_experiments_block")
# model.add_component(doe_block_name, doe_block)
# self.compute_FIM_model = model
pass

self.check_model_labels(model=model)

Expand Down Expand Up @@ -731,9 +733,11 @@ def create_doe_model(self, model=None):
if model is None:
model = self.model
else:
doe_block = pyo.Block()
doe_block_name = unique_component_name(model, "design_of_experiments_block")
model.add_component(doe_block_name, doe_block)
# TODO: Add safe naming when a model is passed by the user.
# doe_block = pyo.Block()
# doe_block_name = unique_component_name(model, "design_of_experiments_block")
# model.add_component(doe_block_name, doe_block)
pass

# Developer recommendation: use the Cholesky decomposition for D-optimality
# The explicit formula is available for benchmarking purposes and is NOT recommended
Expand Down

0 comments on commit 0b08aef

Please sign in to comment.