allow to run forget before pruning #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmaze
reviewed
Jun 24, 2021
djmaze
requested changes
Jun 24, 2021
|
@djmaze, I suppose the typo fixes never appeared on your radar, therefore a small 🎗️ |
|
Oh, sorry! Yes, looks good now. Thanks! |
jeankhawand
pushed a commit
to jeankhawand/resticker
that referenced
this pull request
Aug 30, 2024
allow to run forget before pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to also run
restic forget ..as part of the pruning workflow.The reasons behind this is the following
When running the REST backend with
--append-only, due to security restrictions, setting theRESTIC_FORGET_ARGSas part of the backup will fail.Instead it should be also possible to re-use the
RESTIC_FORGET_ARGSas part of the prune process which is then run directly on the same host as the REST backend to manage forget policies in a central place.I am aware that the
prunecould have been combined as part of theforget, but for clarity I kept this as a seperate step.