Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

double forking for process spawning #211

Closed
wants to merge 2 commits into from

Conversation

sevz17
Copy link
Collaborator

@sevz17 sevz17 commented Mar 29, 2022

Fixes: #177

@djpohly
Copy link
Owner

djpohly commented Mar 29, 2022

I really don't like double-forking. It leaves orphaned processes and messes up the process tree. Is the XWayland implementation forcing our hand on this one?

@sevz17
Copy link
Collaborator Author

sevz17 commented Mar 29, 2022

Is the XWayland implementation forcing our hand on this one?

Yes, try wlroots-next, Xwayland won't be able to spawn

@sevz17
Copy link
Collaborator Author

sevz17 commented Mar 29, 2022

It leaves orphaned processes and messes up the process tree.

We could do something like this to avoid orphaned processes

@djpohly
Copy link
Owner

djpohly commented Mar 29, 2022

Well, I'm still bummed we can't just SIG_IGN the whole thing because of the XWayland fork/wait, but I put together an idea over in #212 which seems to work (and as a bonus, is shorter 😁).

@sevz17
Copy link
Collaborator Author

sevz17 commented Mar 29, 2022

Closed in favor of #212

@sevz17 sevz17 closed this Mar 29, 2022
@sevz17 sevz17 deleted the double-forking branch May 9, 2022 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waitpid for Xwayland fork failed: No child processes
2 participants