Skip to content

Several performance updates to the Angular 1 version #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgalfaso wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Several performance updates to the Angular 1 version #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions app.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ directive("myCalendar", function() {
replace: true,
template:`
<div>
<button class="btn" ng-hide="loaded" ng-click="load()">Load</button>
<button class="btn" ng-show="loaded" ng-click="searchAll()">Search all month</button>
<table ng-if="loaded">
<button class="btn" ng-hide="::loaded ? loaded : undefined" ng-click="load()">Load</button>
<button class="btn" ng-show="::loaded ? loaded : undefined" ng-click="searchAll()">Search all month</button>
<table ng-if="::loaded ? loaded : undefined">
<tr>
<th ng-repeat="day in days" class="day-header">
<th ng-repeat="day in ::days" class="day-header">
{{day}}
</th>
</tr>
<tr ng-repeat="hour in hours">
<td ng-repeat="day in days" class="hour-cell">
<my-calendar-cell hour="{{hour}}" day="{{day}}"></my-calendar-cell>
<tr ng-repeat="hour in ::hours">
<td ng-repeat="day in ::days" class="hour-cell">
<my-calendar-cell hour="{{::hour}}" day="{{::day}}"></my-calendar-cell>
</td>
</tr>
</table>
Expand All @@ -53,14 +53,14 @@ directive("myCalendarCell", function() {
replace: true,
scope: true,
template: `
<div ng-click="cellClicked(day, hour)" ng-class="cellClass()">
<div ng-if="showHour()" class="time">
{{hour}}:00
<div ng-click="cellClicked(day, hour)" class="{{cellClass()}}">
<div ng-show="showHour()" class="time">
{{::hour}}:00
</div>
<div ng-if="showSpinner()">
<div ng-show="showSpinner()">
...
</div>
<div ng-if="showSearchResults()">
<div ng-show="showSearchResults()">
<div>{{status.searchResults.options}}</div>
<div class="result-label">results</div>
</div>
Expand All @@ -69,9 +69,9 @@ directive("myCalendarCell", function() {
link: function(scope, element, attrs) {
scope.day = attrs.day;
scope.hour = attrs.hour;
scope.status = {};
},
controller: function($scope, $rootScope, $timeout) {
$scope.status = {};
$scope.showSpinner = function() {
return $scope.status.isSearching;
}
Expand All @@ -93,19 +93,23 @@ directive("myCalendarCell", function() {
return 'bad-results'
}
}
return '';
}
$scope.cellClicked = function() {
delete $scope.status.searchResults;
$scope.status.searchResults = null;
$scope.status.isSearching = true;
// Simulate an AJAX request:
$timeout(function() {
$scope.status.isSearching = false;
$scope.status.searchResults = {options: Math.floor(Math.random() * 5)};
}, randomMillis());
}, randomMillis(), false).then(localDigest);
}
$scope.$on('allSearchRequested', function() {
$scope.cellClicked();
});
function localDigest() {
$scope.$digest();
}
}
}
}).
Expand Down