fixed issue 17 #97
Open
fixed issue 17 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1-make recording service a bound service to deliver pause and resume.
2-integrate with open source library mp4 parser to append multiple
files to one.
//issues :
1-file naming increment issue.
2-handle case : user press stop after pause
+ update build tools + update dependencies
…ted) with android.support.design.widget.FloatingActionButton
+ Do not start chronometer if the recording is not going to be saved (because of I/O error)
naXa777
reviewed
Aug 20, 2018
| // finalMovie.addTrack(new AppendTrack((Track) tracks)); | ||
| // } catch (IOException e) { | ||
| // e.printStackTrace(); | ||
| // } |
| private void onPauseRecord(boolean pause) { | ||
| if (pause) { | ||
| //pause recording | ||
| mRecordingService.pauseRecording(); | ||
| mPauseButton.setCompoundDrawablesWithIntrinsicBounds | ||
| (R.drawable.ic_media_play ,0 ,0 ,0); | ||
| mRecordingPrompt.setText((String)getString(R.string.resume_recording_button).toUpperCase()); |
There was a problem hiding this comment.
bug: change mPauseButton instead of mRecordingPrompt. set mRecordingPrompt text to "Paused".
| mPauseButton.setCompoundDrawablesWithIntrinsicBounds | ||
| (R.drawable.ic_media_play ,0 ,0 ,0); | ||
| mRecordingPrompt.setText((String)getString(R.string.resume_recording_button).toUpperCase()); | ||
| timeWhenPaused = mChronometer.getBase() - SystemClock.elapsedRealtime(); | ||
| mChronometer.stop(); | ||
| } else { | ||
| //resume recording | ||
| mRecordingService.resumeRecording(); | ||
| mPauseButton.setCompoundDrawablesWithIntrinsicBounds | ||
| (R.drawable.ic_media_pause ,0 ,0 ,0); | ||
| mRecordingPrompt.setText((String)getString(R.string.pause_recording_button).toUpperCase()); |
There was a problem hiding this comment.
bug: change mPauseButton instead of mRecordingPrompt. add mRecordingPrompt.setText(getString(R.string.record_in_progress));
| @@ -13,6 +13,8 @@ | |||
| <!-- Toasts --> | |||
| <string name="toast_recording_start">Recording started</string> | |||
| <string name="toast_recording_finish">Recording saved to</string> | |||
| <string name="toast_recording_paused">Recording paused</string> | |||
| <string name="toast_recording_resumed">Recording resumed</string> | |||
There was a problem hiding this comment.
The string toast_recording_resumed is not used anywhere. Did you forget to add a toast?
…ut to implement Material Design tabs
… fixes occasional application crashes when RecordingFragment is recreated while RecordingService is recording
change mRecordingPrompt properly.
texts minor fixes
|
hi @naXa777 |
MainActivity may be exercised by the monkey; Update gradle build plugin.
gaul
reviewed
Mar 6, 2019
| <orderEntry type="library" exported="" name="Gradle: com.melnykov:floatingactionbutton-1.1.0" level="project" /> | ||
| <orderEntry type="library" exported="" name="Gradle: com.android.support:appcompat-v7-21.0.3" level="project" /> | ||
| <orderEntry type="library" exported="" name="Gradle: com.android.support:support-v4-21.0.3" level="project" /> | ||
| <orderEntry type="library" exported="" name="Gradle: com.android.support:support-annotations:21.0.3@jar" level="project" /> |
There was a problem hiding this comment.
These seem like spurious changes?
gaul
reviewed
Mar 6, 2019
| @@ -36,7 +38,7 @@ | |||
| <string name="dialog_action_no">No</string> | |||
|
|
|||
| <string name="no_saved_recordings_message">No saved recordings</string> | |||
| <string name="pause_recording_button">Pause</string> | |||
| <string name="pause_recording_button">Paused</string> | |||
There was a problem hiding this comment.
Should this be Pause or Paused?
* fix Travis CI pipeline 👷 * Update build tools to 29.0.0
fixes issue dkim0419#25 * `*.tmp` file is now stored in /storage/emulated/0/Android/data/by.naxa.soundrecorder/cache/SoundRecorder.by/* * new method `createDirectory` is created in `Paths` to create directory * optimized imports
Added Adaptive Icons
add template google-services.json
add leakcanary library to `dev` build type
use template google-services.json
Successfully added night mode
…-to-firebase # Conflicts: # app/src/main/java/by/naxa/soundrecorder/SoundRecorderApplication.java
…rebase Migrate to Firebase Crashlytics
fixes dkim0419#38 * add intent for other apps to use the recorder
* Arabic (EG) by AhmadAyman99 * Persian by mahdi takrim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement pause/resume feature in recording