Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify http client #1

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

janishorsts
Copy link
Contributor

Allow specifying the HTTP client to make it more flexible.

We require tracing to improve the observability of the system by using custom HTTP client. E.g. otelhttp.DefaultClient.

Copy link
Owner

@dknight dknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dknight dknight merged commit 5dd7efa into dknight:main Mar 9, 2023
@dknight
Copy link
Owner

dknight commented Mar 9, 2023

Thank you the PR. Will release today a patch version.

@janishorsts janishorsts mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants