Pointer receiver everywhere for historyEngineImpl

Otherwise IDE complains in every method of the historyEngineImpl. Go recommendation: https://go.dev/doc/faq#methods_on_values_or_pointers
dkrotx · Jan 3, 2025 · 2ed12f4 · 2ed12f4
1 parent d81979a
commit 2ed12f4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/service/history/engine/engineimpl/register_domain_failover_callback.go b/service/history/engine/engineimpl/register_domain_failover_callback.go
@@ -161,7 +161,7 @@ func (e *historyEngineImpl) unlockProcessingForFailover() {
 	e.timerProcessor.UnlockTaskProcessing()
 }
 
-func (e historyEngineImpl) failoverPredicate(shardNotificationVersion int64, nextDomain *cache.DomainCacheEntry, action func()) {
+func (e *historyEngineImpl) failoverPredicate(shardNotificationVersion int64, nextDomain *cache.DomainCacheEntry, action func()) {
 	domainFailoverNotificationVersion := nextDomain.GetFailoverNotificationVersion()
 	domainActiveCluster := nextDomain.GetReplicationConfig().ActiveClusterName