Enable testing on Windows with AppVeyor by wilzbach · Pull Request #437 · dlang-community/D-Scanner

wilzbach · 2017-06-10T16:10:32Z

With the build.bat

ghost

I don't think this will fix appveyor but there are old things to remove

ghost · 2017-06-10T19:40:25Z

build.bat

+set DFLAGS=-O -release -inline
+set CORE=
+set LIBDPARSE=
+set STD=


ghost · 2017-06-10T19:40:37Z

build.bat

+
+for %%x in (src\*.d) do set CORE=!CORE! %%x
+for %%x in (src\analysis\*.d) do set ANALYSIS=!ANALYSIS! %%x
+for %%x in (libdparse\experimental_allocator\src\std\experimental\allocator\*.d) do set STD=!STD! %%x


ghost · 2017-06-10T19:40:48Z

build.bat

+for %%x in (src\*.d) do set CORE=!CORE! %%x
+for %%x in (src\analysis\*.d) do set ANALYSIS=!ANALYSIS! %%x
+for %%x in (libdparse\experimental_allocator\src\std\experimental\allocator\*.d) do set STD=!STD! %%x
+for %%x in (libdparse\experimental_allocator\src\std\experimental\allocator\building_blocks\*.d) do set STD=!STD! %%x


ghost · 2017-06-10T19:41:19Z

build.bat

+for %%x in (containers\src\containers\internal\*.d) do set CONTAINERS=!CONTAINERS! %%x
+
+@echo on
+%DC% %CORE% %STD% %LIBDPARSE% %LIBDDOC% %ANALYSIS% %INIFILED% %DSYMBOL% %CONTAINERS% %DFLAGS% -I"libdparse\src" -I"dsymbol\src" -I"containers\src"  -I"libddoc\src" -ofdscanner.exe


remove %STD%

ghost · 2017-06-10T19:50:41Z

build.bat

+setlocal enabledelayedexpansion
+
+IF "%DC%"=="" SET DC="dmd"
+set DFLAGS=-O -release -inline


DFlags should change according to DC. For ldc2 they should be set to -O2 -release (O2 set implicitly inlining on)

another option is to remove -inline. Your call...

wilzbach · 2017-06-11T00:51:26Z

DFlags should change according to DC. For ldc2 they should be set to -O2 -release (O2 set implicitly inlining on)
another option is to remove -inline. Your call...

I used another trick:

IF "%DC%"=="ldc2" SET DC="ldmd2"

In theory this should also fix the issues with the invalid -lib flag ...

ghost · 2017-06-16T11:28:03Z

appveyor.yml

+environment:
+ matrix:
+  - DC: dmd
+    DVersion: nightly


~~nightly~~

ghost · 2017-06-16T11:28:26Z

appveyor.yml

+    DVersion: nightly
+    arch: x64
+  - DC: dmd
+    DVersion: nightly


~~nightly~~

ghost

remove nightly and this will be fine

ghost · 2017-08-19T04:44:51Z

You can now run the tests under windows with build.bat test.

wilzbach · 2017-12-04T03:47:20Z

So now it seems that we run into a lot of funky messages: https://ci.appveyor.com/project/greenify/d-scanner/build/1.0.16/job/34hu2tnnwa23yw4y, e.g.

core.exception.AssertError@src\analysis\alias_syntax_check.d(48): Expected warning:
[warn]: Prefer the new "'alias' identifier '=' type ';'" syntax to the  old "'alias' type identifier ';'" syntax.
		alias abcde = int;
	
From source code at (48:?):
		alias int abcde; // [warn]: Prefer the new "'alias' identifier '=' type ';'" syntax to the  old "'alias' type identifier ';'" syntax.
		alias abcde = int;
	
----------------
0x00007FF6826BD41F in analysis.helpers.assertAnalyzerWarnings.__foreachbody5 at C:\projects\d-scanner\src\analysis\helpers.d(112)

As this hasn't been there this summer, I would assume this is due to a recent change in the compiler.
Is anyone using D-Scanner on Windows and wants to look into this?
(I don't have a Windows machine)

ghost · 2017-12-04T08:19:30Z

build.bat

+@echo off
+setlocal enabledelayedexpansion
+
+IF "%DC%"=="" SET DC="dmd"


Sorry but can you write the commands in lower case, as in the rest of the script ?
Also do you know why there's a major diff failure for this file ?

ghost · 2017-12-05T00:53:24Z

I'm on win right now. build.bat test passed with 2.076.1 and 2.077.1

wilzbach · 2017-12-05T01:12:48Z

I'm on win right now. build.bat test passed with 2.076.1 and 2.077.1

Thanks a lot for the info... This is great :/
Do you have other ideas?

Also do you know why there's a major diff failure for this file ?

I assume because my Vim automatically fixed the line-endings?
It's still weird though.

ghost · 2017-12-05T02:33:39Z

I'll try to setup Appveyor on my fork and see. D-Scanner doesn't fundamentally requires multi platform tests but this is so weird that an explanation must be found.

skl131313 · 2017-12-16T15:23:55Z

@wilzbach
Seems LDC changed their naming convention for releases, your download script for the ldc compiler is broken cause of that.

Also seems build.bat need to be updated for x86?

wilzbach · 2017-12-17T05:43:16Z

Seems LDC changed their naming convention for releases, your download script for the ldc compiler is broken cause of that.

Thanks a lot for getting back to this & finding the root cause. I simply disabled ldc-beta and LDC x86 builds for now.
It will be a lot easier to re-enable them on a separate PR, testing with DMD on Windows already brings a great value and avoids the annoying red cross.

wilzbach force-pushed the enable-appveyor branch from ffa215f to 3aaf15b Compare June 10, 2017 17:47

wilzbach mentioned this pull request Jun 10, 2017

Q: Should we enable AppVeyor (Windows CI) for all repos? dlang-community/discussions#13

Open

ghost suggested changes Jun 10, 2017

View reviewed changes

ghost reviewed Jun 10, 2017

View reviewed changes

wilzbach force-pushed the enable-appveyor branch from 3aaf15b to d63ba26 Compare June 11, 2017 00:38

ghost reviewed Jun 16, 2017

View reviewed changes

appveyor.yml Outdated

environment:

matrix:

- DC: dmd

DVersion: nightly

Copy link

ghost Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~nightly~~

ghost reviewed Jun 16, 2017

View reviewed changes

appveyor.yml Outdated

DVersion: nightly

arch: x64

- DC: dmd

DVersion: nightly

Copy link

ghost Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~nightly~~

ghost suggested changes Jun 16, 2017

View reviewed changes

ghost added the has conflicts label Aug 19, 2017

Enable testing on Windows with AppVeyor

f1e337c

wilzbach force-pushed the enable-appveyor branch from d63ba26 to f1e337c Compare December 4, 2017 03:28

Enable automatic releases for Windows

84e4952

wilzbach removed the has conflicts label Dec 4, 2017

ghost reviewed Dec 4, 2017

View reviewed changes

wilzbach force-pushed the enable-appveyor branch from 5509094 to 672af84 Compare December 5, 2017 01:09

Remove nightly from AppVeyor

67b9697

wilzbach force-pushed the enable-appveyor branch from 672af84 to 67b9697 Compare December 5, 2017 01:10

Fix line endings of code being checked out for Appveyor.

7830edd

Temporarily disable ldc beta + ldc stable x86

c908c8d

wilzbach merged commit 6086c5a into dlang-community:master Dec 17, 2017

wilzbach deleted the enable-appveyor branch December 17, 2017 06:02

Conversation

wilzbach commented Jun 10, 2017

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost Jun 10, 2017

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Jun 11, 2017

Uh oh!

ghost Jun 16, 2017

Choose a reason for hiding this comment

Uh oh!

ghost Jun 16, 2017

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Aug 19, 2017

Uh oh!

wilzbach commented Dec 4, 2017

Uh oh!

ghost Dec 4, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 5, 2017

Uh oh!

wilzbach commented Dec 5, 2017

Uh oh!

ghost commented Dec 5, 2017

Uh oh!

skl131313 commented Dec 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilzbach commented Dec 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghost Jun 10, 2017 •

edited by ghost

Loading

ghost Dec 4, 2017 •

edited by ghost

Loading

skl131313 commented Dec 16, 2017 •

edited

Loading