Merged
Conversation
|
If only people could understand that their tab, from the editor point of view, is only a problem... |
ghost
merged commit 
This was referenced Jun 20, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the few checks where access to the raw source code would make it a lot easier.
Note that this still doesn't fix the checker entirely as lines containing tabs will have a lower line length as libdparse counts columns bytewise. However, there's no easy way around this with no access to the raw source (according to previous discussions this isn't wanted)
In any case this fixes the false positives in Phobos.
The false negatives (with tabs) are a lot less harmless and were totally ignored before.