Skip to content

Merge master into phobos#482

Merged
dlang-bot merged 7 commits intodlang-community:phobosfrom
wilzbach:phobo-master
Jun 28, 2017
Merged

Merge master into phobos#482
dlang-bot merged 7 commits intodlang-community:phobosfrom
wilzbach:phobo-master

Conversation

@wilzbach
Copy link
Member

Keeping the phobos branch up-to-date. phobos an experimental branch of Dscanner in which I can safely apply new features to be rolled out for Phobos.

clYd3r and others added 6 commits June 24, 2017 15:40
A check for public declaration without a documented unittest.
* Enable DScanner checking on Travis
* Fix linter warnings
* Set opequals_tohash_check to disabled
* Set could_be_immutable to 'disabled'
* Split expression back into multiple lines
* Set style to disabled
* Fix Makefile target
Fix AssertError on unknown label in unused_label
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

@dlang-bot dlang-bot merged commit 18f0a0c into dlang-community:phobos Jun 28, 2017
@ghost
Copy link

ghost commented Jun 28, 2017

I see that you enabled the useless initializer but

@wilzbach wilzbach deleted the phobo-master branch June 28, 2017 04:47
@wilzbach
Copy link
Member Author

I see that you enabled the useless initializer but

This is just a periodic sync from master to phobos

#475 is not merged.

Will have a look into finally pushing it.

The only advice i can give you is to disable this check.

It's disabled at Phobos: https://github.com/dlang/phobos/blob/e4afacadb8a291f51444e948dd7b53592e799dbe/.dscanner.ini#L156

@ghost
Copy link

ghost commented Jun 28, 2017

I don't understand, what do you use this branch for ?
Tho i could just ignore it but now i want to know.

@wilzbach
Copy link
Member Author

I don't understand, what do you use this branch for ?

Sorry that I didn't explain - merging & testing features like #460 without needing to wait for review & approval. Inversely, Phobos has proven to be a good battlefield / playground to test new checks. So the intention is also to speed up reviewing by (1) improving a check, (2) showing that it works in real life.

A version of the phobos branch is checked out on Phobos when building Dscanner:
https://github.com/dlang/phobos/blob/master/posix.mak#L524

@ghost
Copy link

ghost commented Jun 28, 2017

Ok now i see that you filter std for the useless init check. Thanks for the explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants