Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opIndex, opDollar and opSlice override on ParseTree #275

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

Zardoz89
Copy link
Contributor

Override opIndex, opDoller and OpSlice like is suggested in #258

So p.children[x].children[y] could be p[x][y] or p.children[1..$-1] could be p[1..$-1] , etc.

@veelo veelo merged commit 8b55a8f into dlang-community:master Mar 24, 2020
@veelo
Copy link
Collaborator

veelo commented Mar 24, 2020

Thanks! Would you mind documenting this in the wiki? No hurry, this becomes only relevant when we tag a new release I guess.

@Zardoz89 Zardoz89 deleted the feature/opIndexChildren branch March 24, 2020 15:35
@Zardoz89
Copy link
Contributor Author

I would take a look, but my english it's horrible. Any idea when the next version would be ready ? (also I noticed that the unit tests are actually failing on the master branch)

@veelo
Copy link
Collaborator

veelo commented Mar 25, 2020

If you want, I can brush off language mistakes. Otherwise I can take over the documentation.
I could tag a new release anytime, were it not for #272. I hope that situation can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants