Set DUB config type to autodetect#281
Merged
PetarKirov merged 1 commit intodlang-community:masterfrom May 22, 2017
Merged
Conversation
This was referenced May 22, 2017
skl131313
approved these changes
May 22, 2017
PetarKirov
approved these changes
May 22, 2017
Member
PetarKirov
left a comment
PetarKirov
left a comment
There was a problem hiding this comment.
LGTM, I just verified that dlang-tour + pr 516 builds with this fix ;)
Member
|
@wilzbach I've just pushed the 0.5.0 tag. |
Member
Author
|
Thanks a lot for the quick review & merge, guys. Very appreciated! |
|
why ? dfmt is well an executable after all. |
Member
Author
And it stays to be, but "autodetect" is a DUB feature which will change the build type to "library" if it's included as dependency to another project as the DLang Tour where |
|
Thanks for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change and a new preview release tag afterwards is needed to integrate
dfmtinto the DLang Tour (dlang-tour/core#516) (as a "Format" button).