-
Notifications
You must be signed in to change notification settings - Fork 47
Fix bintray upload #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bintray upload #319
Conversation
b093bbe to
78938fe
Compare
leandro-lucarella-sociomantic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why does it have a failing "push" travis build?
.travis.yml
Outdated
| deploy: | ||
| provider: script | ||
| script: beaver bintray upload build/last/pkg/*.deb | ||
| script: beaver bintray upload build/last/pkg/*.deb -d dlang-community/apt/dfmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the option should go before the arguments: beaver bintray upload -d dlang-community/apt/dfmt build/last/pkg/*.deb
78938fe to
4aa3458
Compare
|
because I force-pushed a tag to dlang-community, I guess. |
4aa3458 to
ddc97c5
Compare
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force push again
|
Why are you pushing tags with unmerged changes? |
|
to test the bintray deployment. |
|
Huh? Why can't you do this your fork? |
|
in my fork the deployment worked when I tested it. |
|
That's probably because your personal bintray repo didn't coincide with the one here (you probably had |
|
OK, let's move on with this. Can you please force-push again the 0.5.3 tag to its originally released commit and create a new release 0.5.4 with this merge? |
|
I can no longer remember which one the original release had |
|
Seriously? Who made the tag originally? It was like 2 days ago, from the list of commits in master it shouldn't be too hard to find out. Also, I just saw there is a v0.6.0-alpha.1 release that is 41 commits behind 0.5.3. Also, between 0.5.0 and 0.5.3 there were new features added. It would be nice to make release numbers have some sort of sense. Also, there is no GitHub release for 0.5.1, 0.5.2 and 0.5.3. This is super messy. We need to regroup and do things proper here. Next release should be 0.6.0, let's forget about the 0.5.x mess and start over with some order. |
Well
Anyhow the only public dependent repo on |
I don't know exactly what does that mean, can you send a link or something?
OK, so at least that should give us the original commit of 0.5.3.
OK, sorry if I'm asking a lot of very basic questions (I guess there is a mismatch here because I might assume a lot of knowledge of how we work at sociomantic and you might assume a lot of knowledge about how things work at dlang/community and I'm not all that involved in that process :). What do you mean by skip and by -alpha.1 tags? Are there more than v0.6.0-alpha.1?
What do you mean by match here?
Why would we need to do that? Sorry again if I'm asking stupid questions, but I also don't use
Yes, this is what's suggested by neptune BTW. |
Yeah, it's not well documented: https://github.com/dlang/ci/blob/master/vars/runPipeline.groovy#L51 Example from dlang/phobos#6099 -> https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fphobos/detail/PR-6099/2/pipeline/209 (it checks out 0.5.3 - not 0.6.0-alpha.1)
No worries, things are always under-documented at @dlang
I meant that both DUB and ci.dlang.io skip/ignore/don't look at major.minor.patch- versions.
http://code.dlang.org/package-format?lang=sdl#version-specs
See e.g. dlang-community/discussions#28 So at the moment every time when a PR is merged at libdparse, dsymbol etc., all repos depending on it, need to be bumped as they won't take advantage of the bug fix otherwise. I hope that helps to reduce our the barrier and differences a bit. Otherwise, just hit "reply" ;-) |
|
OK, I can't say I have the whole picture clear, but I think I understand the context a bit better, there seems to be a lot of interactions between projects, they are not managed very independently it seems. Anyway, I suggest to keep the discussion about how to proceed in the future, and in particular about releasing current master as 0.6.0 in #320 :) |
|
@leandro-lucarella-sociomantic @wilzbach I just fixed the v0.5.3 tag. |
|
Thanks! |
Simple fixup