Improve section parsing (don't include the last line)#31
Merged
Hackerpilot merged 1 commit intodlang-community:masterfrom Jun 28, 2017
Merged
Improve section parsing (don't include the last line)#31Hackerpilot merged 1 commit intodlang-community:masterfrom
Hackerpilot merged 1 commit intodlang-community:masterfrom
Conversation
wilzbach
commented
Jun 19, 2017
src/ddoc/macros.d
Outdated
| while (!lexer.empty && lexer.front.type == Type.whitespace) | ||
|
|
||
| // parentheses might be used in the key | ||
| while (!lexer.empty && lexer.front.type.among(Type.whitespace, Type.lParen, Type.rParen, Type.word)) |
Member
Author
There was a problem hiding this comment.
One also might argue that the occurrence at Phobos should be fixed:
Contributor
There was a problem hiding this comment.
Having looked at the changes in Phobos it seems that Phobos was wrong...
Contributor
There was a problem hiding this comment.
Ddoc spec says:
Each line that starts with an identifier followed by an '=' starts a new parameter description.
I'm pretty sure that parens aren't part of identifiers anywhere else in D, so is it really a good idea to make an exception here?
This was referenced Jun 20, 2017
Member
Author
Luckily my PR at Phobos was merged, so I could drop the {L,R}parens allowance in Ddoc parameters :) |
wilzbach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into quite some trouble when trying to turn all Dscanner checks for Phobos.
I hope the added examples are self-documentary.