-
-
Notifications
You must be signed in to change notification settings - Fork 32
Add DStep to the tested projects #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @jacob-carlborg! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. |
|
|
00f14c4 to
ea2dc01
Compare
wilzbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't you tag a new release? The idea behind not using master is that the latest release will be more stable and will change less frequently.
|
I looked down the clone to the current master. I'll remove this later when a new tag is added for DStep. |
|
It looks like the Jenkins Git checkout plugin only supports tags and branches :O |
|
Added a tag. |
|
It's Dub that is failing. |
|
Yeah that's unrelated and due to #135 However, I can't overwrite the CI check here. I will try to restart it. |
|
Downloading a 200+MiB clang+llvm for every test is not OK, please don't unnecessarily waste resources, simply because they are not your resources. You should also fix your Travis-CI tests to either use packages or at least cache the downloads, it's currently downloading 13x200+MiB from the llvm site. |
|
FYI @jacob-carlborg |
Should I cache that to reduce the traffic to the LLVM site? Because the Travis documentation says: "Large files that are quick to install but slow to download do not benefit from caching, as they take as long to download from the cache as from the original source:" [1] [1] https://docs.travis-ci.com/user/caching/#Things-not-to-cache |
I cannot use packages because they are too old. I want to control myself which versions of LLVM I support. |
No description provided.