Skip to content

Conversation

@jacob-carlborg
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @jacob-carlborg! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

@jacob-carlborg
Copy link
Contributor Author

jacob-carlborg commented Jan 28, 2018

Why is it checking out the latest tag? I want it to test master.
I think I figured it out.

@jacob-carlborg jacob-carlborg force-pushed the dstep branch 3 times, most recently from 00f14c4 to ea2dc01 Compare January 28, 2018 10:10
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you tag a new release? The idea behind not using master is that the latest release will be more stable and will change less frequently.

@jacob-carlborg
Copy link
Contributor Author

I looked down the clone to the current master. I'll remove this later when a new tag is added for DStep.

@wilzbach
Copy link
Contributor

It looks like the Jenkins Git checkout plugin only supports tags and branches :O

@jacob-carlborg
Copy link
Contributor Author

Added a tag.

@jacob-carlborg
Copy link
Contributor Author

It's Dub that is failing.

@wilzbach
Copy link
Contributor

Yeah that's unrelated and due to #135

However, I can't overwrite the CI check here. I will try to restart it.

@dlang-bot dlang-bot merged commit ed9654e into dlang:master Jan 28, 2018
@jacob-carlborg jacob-carlborg deleted the dstep branch January 28, 2018 16:57
@MartinNowak
Copy link
Member

Downloading a 200+MiB clang+llvm for every test is not OK, please don't unnecessarily waste resources, simply because they are not your resources.
https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fci/detail/PR-146/2/pipeline/207#step-472-log-8
I've installed libclang-4.0-dev on all testers. I'm reverting this until dstep manages to detect that package.
#148
Let us know if you need sth. else installed.

You should also fix your Travis-CI tests to either use packages or at least cache the downloads, it's currently downloading 13x200+MiB from the llvm site.
https://travis-ci.org/jacob-carlborg/dstep/builds/334364953

@MartinNowak
Copy link
Member

FYI @jacob-carlborg

@jacob-carlborg
Copy link
Contributor Author

You should also fix your Travis-CI tests to either use packages or at least cache the downloads, it's currently downloading 13x200+MiB from the llvm site.
https://travis-ci.org/jacob-carlborg/dstep/builds/334364953

Should I cache that to reduce the traffic to the LLVM site? Because the Travis documentation says:

"Large files that are quick to install but slow to download do not benefit from caching, as they take as long to download from the cache as from the original source:" [1]

[1] https://docs.travis-ci.com/user/caching/#Things-not-to-cache

@jacob-carlborg
Copy link
Contributor Author

You should also fix your Travis-CI tests to either use packages.

I cannot use packages because they are too old. I want to control myself which versions of LLVM I support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants