Fix #65 - the Dlang-Bot should use the 'Enhancement' label

[wilzbach]

Rather trivial.

At this point we don't know about the existing labels, even though we have requested it before.
I will change our GH API in another PR to use internal caching and thus avoid this unnecessary request (it doesn't really hurt for now though).

[dlang-bot]

Thanks for your pull request, @wilzbach!

[PetarKirov]

No need for .array here.

[PetarKirov]

(This comment is obsoleted if we agree on my other one below.)

There's no need for .array.sort().uniq:

• You don't need uniq for canFind
• Sorting is only used/needed for uniq, since plain linear search is faster without sorting than if you sort first ( O(n) vs O(n*log(n) + log(n)) )
• uniq hides the SortedRange properties, so you *find won't perform binary search with UniqRange
• array is not needed since sorting is not needed
  (Sorry for not pointing out this earlier, but I just looked at the code more thoroughly)

[PetarKirov]

Hmm, it seams that .array.sort.uniq.array may be needed after all.
That's because I think we need to add "Bug fix" label if there are more than one bugs attached to a PR and at least one of those bugs is not an enhancement request. Probably quite rare, and that's why I think it's worth labeling them.

if (bugzillSeverities.canFind("enhancement"))
    labels ~= "Enhancement";
if (bugzillSeverities.length > 2)
    labels ~= "Bug fix";

[wilzbach]

(This comment is obsoleted if we agree on my other one below.)
There's no need for .array.sort().uniq:

Hmm, it seams that .array.sort.uniq.array may be needed after all.
That's because I think we need to add "Bug fix" label if there are more than one bugs attached to a PR and at least one of those bugs is not an enhancement request. Probably quite rare, and that's why I think it's worth labeling them.

Not really sure about this. This should be very rare. Let's KISS and drop .array.sort.uniq then.

[wilzbach]

Never say never: dlang/phobos#5511 (comment)