Skip to content

DUB: use stable DMD#1592

Merged
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:dub-use-stable-dmd
Mar 3, 2017
Merged

DUB: use stable DMD#1592
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:dub-use-stable-dmd

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Mar 1, 2017

Change the DUB invocation to rely on STABLE_DMD

CC @MartinNowak

@MartinNowak
Copy link
Member

THX

Tried this as well, the assert_writeln_magic script failed to compile for me (w/ 2.069.0). Also stable_dmd needs to be in the dependencies for the target.

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 1, 2017

Tried this as well, the assert_writeln_magic script failed to compile for me (w/ 2.069.0). Also stable_dmd needs to be in the dependencies for the target.

Hmm yeah I think libdparse needs at least 2.071 due to its dependence on std.experimental.allocator.
I couldn't find an existing target to build the latest PHOBOS_LIB in this Makefile, hence I added it.

Does this help you?

@MartinNowak
Copy link
Member

No, our policy for tools and external dependencies is to always use stable compiler versions to avoid complications/incompatibilities.
We might update STABLE_DMD to 2.071, I guess.

@wilzbach wilzbach force-pushed the dub-use-stable-dmd branch from d349b75 to 626146e Compare March 1, 2017 23:06
@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 1, 2017

No, our policy for tools and external dependencies is to always use stable compiler versions to avoid complications/incompatibilities.

Ok.

We might update STABLE_DMD to 2.071, I guess.

With the PIC changes on Ubuntu, 2.072.2 seems a more reasonable choice as "stable" version.
See this PR for a previous precedent: dlang/dmd#6411

@wilzbach wilzbach force-pushed the dub-use-stable-dmd branch from 626146e to 209e36b Compare March 1, 2017 23:10
@MartinNowak
Copy link
Member

Still getting

2017-03-02T01:17:16.028:assert_writeln_magic.d:parseFile:188 ../phobos/out/std_c_wcharh.d is empty
object.Exception@/usr/include/dmd/phobos/std/stdio.d(903): rawRead must take a non-empty buffer
----------------
/usr/include/dmd/phobos/std/stdio.d:903 @safe ubyte[] std.stdio.File.rawRead!(ubyte).rawRead(ubyte[]) [0x68fd30]
assert_writeln_magic.d:190 void assert_writeln_magic.parseFile(immutable(char)[], immutable(char)[]) [0x66dbad]
assert_writeln_magic.d:257 _Dmain [0x66e2fa]
??:? _D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv [0x73afc3]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0x73aeeb]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll() [0x73af68]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0x73aeeb]
??:? _d_run_main [0x73ae57]
??:? main [0x6a6737]
??:? __libc_start_main [0x2d1bf400]
posix.mak:556: recipe for target '.generated/phobos-prerelease/out/std_c_wcharh.d' failed
make: *** [.generated/phobos-prerelease/out/std_c_wcharh.d] Error 1

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 2, 2017

../phobos/out/std_c_wcharh.d is empty

Do you run the style Makefile target there? This file in out seems to be a left-over ...

@MartinNowak
Copy link
Member

Do you run the style Makefile target there? This file in out seems to be a left-over ...

Mmh, works now after recleaning phobos.

@MartinNowak MartinNowak merged commit b17fcc4 into dlang:master Mar 3, 2017
@wilzbach wilzbach deleted the dub-use-stable-dmd branch December 18, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments