Remove special casing for objc.d from the Posix makefile#1636
Remove special casing for objc.d from the Posix makefile#1636schuetzm merged 1 commit intodlang:masterfrom
objc.d from the Posix makefile#1636Conversation
This file is now shared for all platforms after the Objective-C integration refactoring: dlang/dmd#6679.
|
@ibuclaw @WalterBright This is required for the DAutoTest to pass for dlang/dmd#6679. I guess this will fail until dlang/dmd#6679 is merged. |
|
Looks fine. FYI @CyberShadow. |
ibuclaw
left a comment
There was a problem hiding this comment.
I guess the same will need to be done for objc_glue too if you plan on changing that too?
Yes, one step at the time 😃. I'll wait until I have the PR for the compiler ready. |
|
LGTM, but I'm not going to merge this because it looks like by itself it would break master. I understand that merging this simultaneously with dlang/dmd#6679 would fix things again, so whoever merges dlang/dmd#6679 should merge this immediately after. Even better would be to do this in three steps to avoid breaking master at all. E.g. in the dlang.org makefile, detect whether |
|
@CyberShadow auto merging has been enabled for the other PR dlang/dmd#6679, can this be merged now? Looks like Iain doesn't have permission to merge this. |
|
@CyberShadow dlang/dmd#6679 has been merged. This can now be merged as well. |
|
Thanks. |
|
Thanks for handling this @schuetzm, just got back home :) |
This file is now shared for all platforms after the Objective-C integration refactoring: dlang/dmd#6679.