Unify DDoc Makefile build variables#1687
Conversation
wilzbach
force-pushed
the
unify_ddoc_vars
branch
2 times, most recently
from
dd8f3e6 to
19e894c
Compare
posix.mak
Outdated
| # | ||
|
|
||
| include osmodel.mak | ||
| PWD=$(realpath .) |
There was a problem hiding this comment.
The idea here to get rid of all the repeated realpath clutter
There was a problem hiding this comment.
realpath resolves symlinks and unnecessarily exposes implementation details in log files or even built files. We should get rid of it and just use $(pwd) instead.
|
|
||
| ################################################################################ | ||
| # Ddoc build variables | ||
| ################################################################################ |
There was a problem hiding this comment.
If we agree on renaming _STABLE to _LATEST, this should be changed as well.
However without #1689 it the naming is stable...
| ${MAKE} --directory=${DRUNTIME_DIR} -f posix.mak target doc \ | ||
| ${MAKE} --directory=${DRUNTIME_DIR} -f posix.mak target doc $(DDOC_VARS_HTML) \ | ||
| DOCDIR=${DOC_OUTPUT_DIR}/phobos-prerelease \ | ||
| DOCFMT="$(addprefix `pwd`/, $(STD_DDOC_PRE))" |
There was a problem hiding this comment.
dlang/druntime#1834 changes DOCDIR and DOCFMT to their more common names. After the next release (2.074.2), these lines can be removed for all druntime doc targets.
You mean |
|
Thanks!
Looks like there's still a |
|
|
You also added a subtle breakage, now this makefiles requires any |
|
|
||
| ../%-${DUB_VER} : | ||
| git clone --depth=1 -b v${DUB_VER} ${GIT_HOME}/$* $@ | ||
| $(PWD)/%-${DUB_VER} : |
There was a problem hiding this comment.
Furthermore this broke the clone targets, they are located at $(PWD)/../%-${LATEST}.
4 participants
Ideally this should cleanup our Ddoc variables mess. It's noteworthy that Druntime uses completely different ones, so the idea is to change the build files at Druntime afterwards.
If I did it right, no changes should be detected by DAutoTest.