Skip to content

Comments

Enable section links to the DStyle#1813

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:links-dstyle
Jul 10, 2017
Merged

Enable section links to the DStyle#1813
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:links-dstyle

Conversation

@wilzbach
Copy link
Contributor

Linking to sections of the DStyle can be useful. Observed here: dlang/phobos#5581 (comment)

CC @JackStouffer @CyberShadow

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach changed the title Enale section links to the DStyle Enable section links to the DStyle Jul 10, 2017
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one nit.

dstyle.dd Outdated
Macros:
TITLE=The D Style
LISTSECTION=$(H4 $1) $(UL $+)
LISTSECTION=$(H4 $(LNAME2 $2, $1)) $(UL $(SKIPFIRST $+))
Copy link
Member

@PetarKirov PetarKirov Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer LISTSECTION=$(H4 $(LNAME2 $1, $2)) $(UL $(SKIPFIRST $+)) to be consistent with the use of LNAME2 above in the rest of the document.

@wilzbach
Copy link
Contributor Author

I would prefer LISTSECTION=$(H4 $(LNAME2 $1, $2)) $(UL $(SKIPFIRST $+)) to be consistent with the use of LNAME2 above in the rest of the document.

Ok. Changed.

@dlang-bot dlang-bot merged commit 990d61d into dlang:master Jul 10, 2017
@wilzbach wilzbach deleted the links-dstyle branch July 10, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants