Merged
Conversation
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
- sitemap contained invalid links to ../dmd/changelog/PR7356.dd.html caused by conflicting CHANGELOG_FILES variable
MartinNowak
force-pushed
the
fix_chmgen_tag
branch
from
d7ed5e0 to
edef82f
Compare
MartinNowak
commented
Dec 12, 2017
| SPEC_DD=$(addsuffix .dd,$(SPEC_ROOT)) | ||
|
|
||
| CHANGELOG_FILES=$(basename $(subst _pre.dd,.dd,$(wildcard changelog/*.dd))) | ||
| CHANGELOG_FILES:=$(basename $(subst _pre.dd,.dd,$(wildcard changelog/*.dd))) |
Member
Author
There was a problem hiding this comment.
It's often a good use early evaluation in make variables to avoid surprised by later reassignments :o.
wilzbach
approved these changes
Dec 12, 2017
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Totally lost track of this. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caused by conflicting CHANGELOG_FILES variable