Update spec for multiple selective imports#2131
Merged
dlang-bot merged 3 commits intodlang:masterfrom Feb 6, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
andralex
approved these changes
Jan 28, 2018
Member
andralex
left a comment
andralex
left a comment
There was a problem hiding this comment.
Thanks! Please mind the dautotest failure.
andralex
approved these changes
Jan 28, 2018
wilzbach
force-pushed
the
imports-spec
branch
from
7217f3c to
76d6d0b
Compare
quickfur
reviewed
Jan 29, 2018
spec/module.dd
Outdated
|
|
||
| $(SPEC_RUNNABLE_EXAMPLE_COMPILE | ||
| --- | ||
| import std.stdio : writeln, std.file : write, std.ascii; |
Member
There was a problem hiding this comment.
What about an example that has multiple symbols per module? E.g.,
import std.stdio : writeln, writefln, std.file : write;
Member
There was a problem hiding this comment.
(TBH I don't really like this syntax, because it mixes module names and symbols and is harder to read. But since it's in the spec, it should be illustrated properly.)
wilzbach
force-pushed
the
imports-spec
branch
from
76d6d0b to
cf44d16
Compare
Member
|
Andrei has approved these changes and it looks like Wilzbach has addressed all issues, so I'm gonna merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at updating the spec for the changes in dlang/dmd#6589
I wasn't so sure about the grammar changes.
(
grammar.ddwould also need an update)See also: https://dlang.org/changelog/pending.html#multi_module_selective_imports