Skip to content

Comments

Build changelog menu dynamically (replace bash with D code)#2159

Merged
dlang-bot merged 3 commits intodlang:masterfrom
wilzbach:build-changelog-menu
Feb 2, 2018
Merged

Build changelog menu dynamically (replace bash with D code)#2159
dlang-bot merged 3 commits intodlang:masterfrom
wilzbach:build-changelog-menu

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Feb 1, 2018

Now that we have the ddoc_preprocessor, we can slowly remove all these old things.
Advantage of auto-generating these files is that less unrelated changes will pop up on a PR.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

What's "ZipException: no end record"? Another Dub failure mode?

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 2, 2018

Yes, but we fixed that one quite recently: dlang/dub#1339
That's also the reason for 2.078.2 ;-)

@CyberShadow
Copy link
Member

Now that we have the ddoc_preprocessor, we can slowly remove all these old things.

Great!

Looks like it currently generates a broken link to 2.078.2_pre , is that intentional?

@wilzbach wilzbach force-pushed the build-changelog-menu branch from 4680134 to 869eee7 Compare February 2, 2018 13:23
@wilzbach wilzbach force-pushed the build-changelog-menu branch from 869eee7 to 0b75464 Compare February 2, 2018 13:36
@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 2, 2018

Looks like it currently generates a broken link to 2.078.2_pre , is that intentional?

Kinda - it mimicked the update_nav.sh script 1:1 and Martin typically hasn't run it for last beta releases. Though it has been done in the past and so I would put it in the "an additional step which has been accidentally forgotten but can't be forgotten anymore category".
Anyhow we fixed the prerelease pages to point to changelog/<ver>.html to have stable URLs a while ago.

While I updated the URL, I used it as an opportunity to improve the text for the preview item to:

image

Note that I also had to bump the DMD version on CircleCi - as interestingly the changelog is built by the release tool.

@dlang-bot dlang-bot merged commit 542a447 into dlang:master Feb 2, 2018
@CyberShadow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants