Check all files for undefined ddoc#2175
Merged
andralex merged 1 commit intodlang:masterfrom Feb 5, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
requested review from
CyberShadow,
MartinNowak,
WalterBright and
andralex
as code owners
2 tasks
wilzbach
force-pushed
the
undefined_ddoc
branch
from
8710781 to
bb82efc
Compare
andralex
approved these changes
Feb 5, 2018
dlang.org.ddoc
Outdated
| DBLOG_LATEST_LINK2=https://dlang.org/blog | ||
| DBLOG_LATEST_TITLE2= | ||
| DMDSRC=$(HTTPS github.com/dlang/dmd/blob/master/src/dmd/$0, $0) | ||
| DOLLAR=$ |
| @@ -155,6 +155,7 @@ DBLOG_LATEST_DATE2= | |||
| DBLOG_LATEST_LINK2=https://dlang.org/blog | |||
Member
There was a problem hiding this comment.
Pedantically this should be $(HTTPS dlang.org/blog). That way if the macro ever makes it in non-html documentation, there's no problem with it.
Contributor
Author
There was a problem hiding this comment.
Not related to this PR and it's only used for the front page. The reason it's defined here, is that DAutoTest doesn't error with undefined macros as these are dynamically injected.
| char s[8]; | ||
| strcpy(s, "foo"); | ||
| printf("string = '$(B %s)'\n", s); | ||
| printf("string = '%s'\n", s); |
Member
There was a problem hiding this comment.
Custom escapes inside code are mightily difficult in latex, too. I'm very glad we're steering clear off them.
wilzbach
force-pushed
the
undefined_ddoc
branch
from
bb82efc to
92391a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the undefined ddoc check for all files and fixes the violations.