Skip to content

Conversation

@jacob-carlborg
Copy link
Contributor

This is the spec update for dlang/dmd#9179.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @jacob-carlborg! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@jacob-carlborg
Copy link
Contributor Author

@thewilsonator DMD PR has been merged.

@thewilsonator
Copy link
Contributor

You need to escape all your , in $(P some, text) with $(P $(ARGS some, text)) see #2453 (comment)

@adamdruppe
Copy link
Contributor

ddoc is so unbelievably bad. you guys really should ditch it so writers can spend less time on syntax and more time on content. just fyi.

@jacob-carlborg
Copy link
Contributor Author

You need to escape all your , in $(P some, text) with $(P $(ARGS some, text)) see #2453 (comment)

You're kidding? The existing text doesn't do that.

@thewilsonator
Copy link
Contributor

Oh I was dealing with lists, hmm. IDK what the problem is then.

@thewilsonator
Copy link
Contributor

you guys really should ditch it

Would love to.

@jacob-carlborg
Copy link
Contributor Author

@thewilsonator it's green now. I had an extra comma where there shouldn't be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants