add new feature AliasAssign to spec#2868
Merged
mdparker merged 2 commits intodlang:masterfrom Jul 3, 2021
Merged
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
WalterBright
force-pushed
the
AliasAssign
branch
from
f42988a to
b5bed88
Compare
mdparker
previously requested changes
Mar 7, 2021
Member
|
@WalterBright If you can address my review comments, I can merge this as soon as #2919 is good to go. |
mdparker
approved these changes
Jul 3, 2021
CyberShadow
reviewed
Jul 4, 2021
|
|
||
| $(GRAMMAR | ||
| $(GNAME AliasAssign): | ||
| $(I Identifier) $(D =) $(GLINK Type) |
Member
There was a problem hiding this comment.
Type is declared in type.dd, not in this file.
CyberShadow
reviewed
Jul 4, 2021
| $(GLINK2 function, FuncDeclaration) | ||
| $(GLINK VarDeclarations) | ||
| $(GLINK AliasDeclaration) | ||
| $(GLINK AliasAssign) |
Member
There was a problem hiding this comment.
This isn't right because then it is syntactically ambiguous in function scope. It is the same syntax as AssignExpression (unless Type happens to be a FundamentalType or otherwise unambiguously a type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation: dlang/dmd#11846