-
-
Notifications
You must be signed in to change notification settings - Fork 379
Replace GRAMMAR_INFORMATIVE
by INFORMATIVE_GRAMMAR
#3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
I just checked the prospect Grammar page and it looks good. |
@ntrel or @thewilsonator, one of you might take a quick look at this. Thanks in advance 😄 |
Why is this necessary or desired? |
@thewilsonator, there is a little D program that collects all blocks starting with Before, the
|
Surely you can do - enum grammarKey = "$(GRAMMAR";
+ enum grammarKey = "$(GRAMMAR"; then. Or is that intended to pick up |
Is this a joke that I don’t get? Those two lines are exactly the same.
|
Nope, that was supposed to be - enum grammarKey = "$(GRAMMAR";
+ enum grammarKey = "$(GRAMMAR "; my bad. |
Most definitely, a space or newline could follow. Possibly also something else. I’ll keep it as-is for now. The Right Thing would be to check for the word ending, but that’s non-trivial. |
@ntrel or @thewilsonator, merge? |
@thewilsonator, merge? |
Because
GRAMMAR_INFORMATIVE
starts withGRAMMAR
, there are stray ones included in the grammar spec.