Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated info from dmd manual #4194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 21, 2025

A Google Summer of Code contributor came across build instructions here, which are outdated. Upon closer inspection, lots of other info on this page is out of date as well.

  • omf support is removed, so the Digital Mars C compiler (dmc) is useless for D now
  • dman, obj2asm, dumpobj, optlink, shell, make are not part of a dmd release anymore
  • the samples folder is removed

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Comment on lines -907 to -910
$(H2 $(LEGACY_LNAME2 compiling_dmd, compiling-dmd, Compiling dmd))

$(P Complete source code is provided to build the compiler.
Follow these steps:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t we keep at least some of that? Maybe replace it with a link to a Windows build of GNU Make (as in the Makefile itself) and note that building is as easy as running make from a Phobos directory that sits next to the dmd directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make unittest and make unittest-debug might also be noteworthy mentions.

@ntrel
Copy link
Contributor

ntrel commented Mar 26, 2025

/tmpfs/dautotest-work/repo/dlang.org/web/dmd-osx.html:113: [RAW MACRO LEAKAGE] $(D_S dmd - Mac OS X D Compiler,
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-windows.html:113: [RAW MACRO LEAKAGE] $(D_S dmd - Windows D Compiler,
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-osx.html:134: [RAW MACRO LEAKAGE]     $(OL
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-windows.html:134: [RAW MACRO LEAKAGE]     $(OL
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-freebsd.html:113: [RAW MACRO LEAKAGE] $(D_S dmd - FreeBSD D Compiler,
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-freebsd.html:134: [RAW MACRO LEAKAGE]     $(OL
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-linux.html:113: [RAW MACRO LEAKAGE] $(D_S dmd - Linux D Compiler,
/tmpfs/dautotest-work/repo/dlang.org/web/dmd-linux.html:134: [RAW MACRO LEAKAGE]     $(OL
8 errors found. Exiting.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some more

dmc.zip (C and C++ compiler)</a> for Win32
(not required, but it complements dmd for Windows)
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this last one you want to keep

@@ -69,16 +63,12 @@ performs these steps automatically.
Unzip the files in the root directory.
$(D dmd.zip) will create
a $(D $(DMDDIR)) directory with all the files in it.
$(D dmc.zip) will create
a $(D \dm) directory with all the files in it.
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants