workaround Issue 19974 - changed naked asm parameter offsets#10045
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jun 16, 2019
Merged
workaround Issue 19974 - changed naked asm parameter offsets#10045dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
- fixes building dmd for Win32 with 2.086 host compiler (nightly and upcoming 2.087.0-beta.1)
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10045" |
thewilsonator
approved these changes
Jun 16, 2019
Contributor
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
I trust you know what you're doing here.
Member
Author
|
I checked dmd's codegen for the non-asm function and it's quite a bit less efficient, hence I choose to repair the naked asm instead. |
Member
|
Yah, profiling of dmd shows the speed of that function is a big deal. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(nightly and upcoming 2.087.0-beta.1)