Skip to content

Fix Issue 20025 - alias this combined with a copy constructor seems to lead to undefined behaviour.#10137

Merged
dlang-bot merged 1 commit intodlang:stablefrom
RazvanN7:Issue_20025
Jul 4, 2019
Merged

Fix Issue 20025 - alias this combined with a copy constructor seems to lead to undefined behaviour.#10137
dlang-bot merged 1 commit intodlang:stablefrom
RazvanN7:Issue_20025

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jul 4, 2019

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 4, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20025 normal alias this combined with a copy constructor seems to lead to undefined behaviour.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10137"

@ghost
Copy link

ghost commented Jul 4, 2019

LGTM but can I suggest to target stable now that 2.087 is released ?

@RazvanN7 RazvanN7 changed the base branch from master to stable July 4, 2019 09:48
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Jul 4, 2019

@Basile-z done.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


struct B
{
static int value = 77;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks too deep.

@dlang-bot dlang-bot merged commit 8c27bbe into dlang:stable Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants