Skip to content

Fix issue 17885: use the correct expression's type when creating temporary for remove() call#10140

Merged
dlang-bot merged 1 commit intodlang:stablefrom
FeepingCreature:fix/issue-17885-backend-typo-strikes-again
Jul 5, 2019
Merged

Fix issue 17885: use the correct expression's type when creating temporary for remove() call#10140
dlang-bot merged 1 commit intodlang:stablefrom
FeepingCreature:fix/issue-17885-backend-typo-strikes-again

Conversation

@FeepingCreature
Copy link
Contributor

Everybody does typos.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 5, 2019

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
17885 critical Unable to remove a tuple from associative array.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10140"

@thewilsonator
Copy link
Contributor

Stable?

@FeepingCreature
Copy link
Contributor Author

Ah yeah, probably good. Hang on.

@FeepingCreature FeepingCreature changed the base branch from master to stable July 5, 2019 08:48
@FeepingCreature FeepingCreature force-pushed the fix/issue-17885-backend-typo-strikes-again branch from 22f16f9 to 4b8438a Compare July 5, 2019 08:49
@dlang-bot dlang-bot merged commit f811228 into dlang:stable Jul 5, 2019
@FeepingCreature FeepingCreature deleted the fix/issue-17885-backend-typo-strikes-again branch July 5, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants