Skip to content

Conversation

@UplinkCoder
Copy link
Member

No description provided.

@UplinkCoder UplinkCoder requested a review from WalterBright as a code owner July 9, 2019 19:35
@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 9, 2019

Thanks for your pull request, @UplinkCoder!

Bugzilla references

Auto-close Bugzilla Severity Description
20035 critical [ICE] Segmentation fault in ExpressionPrettyPrintVisitor::visit(IntegerExp*) at dmd/hdrgen.d:1775

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10155"

@UplinkCoder UplinkCoder force-pushed the fix_vcg_ast branch 3 times, most recently from 62c62d7 to 48b015a Compare July 9, 2019 19:47
@UplinkCoder UplinkCoder changed the base branch from master to stable July 9, 2019 19:48
@UplinkCoder UplinkCoder changed the title Fix bug 20035 - segfaullt in vcg-ast Fix bug 20035 - segfault in vcg-ast Jul 9, 2019
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcase?

@UplinkCoder
Copy link
Member Author

You're quick @wilzbach good thing you asked for one :)
For some reason the comparison tries to deference the pointer.

@UplinkCoder
Copy link
Member Author

@wilzbach @ibuclaw ready for merge.

@thewilsonator thewilsonator dismissed wilzbach’s stale review July 10, 2019 04:35

Test case added

@dlang-bot dlang-bot merged commit e9b518c into dlang:stable Jul 10, 2019
wilzbach pushed a commit to wilzbach/dmd that referenced this pull request Jul 30, 2019
Fix bug 20035 - segfault in vcg-ast
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants