fix debug assertion for C++ dtor #10156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10156" |
Contributor
|
Might as well target stable. |
thewilsonator
approved these changes
Jul 10, 2019
rainers
force-pushed
the
cpp_debug_assert
branch
from
293ea2b to
2a6a330
Compare
Member
Author
Ok, done. |
WalterBright
previously requested changes
Jul 10, 2019
Member
WalterBright
left a comment
WalterBright
left a comment
There was a problem hiding this comment.
a C++ dtor gets its vtblIndex later (and might even be added twice to the vtbl) This assert triggers when compiling druntime with a debug compiler, namely with core.stdcpp.exception.
Please add this as a comment.
a C++ dtor gets its vtblIndex later (and might even be added twice to the vtbl)
rainers
force-pushed
the
cpp_debug_assert
branch
from
2a6a330 to
2646418
Compare
Member
Author
Amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a C++ dtor gets its vtblIndex later (and might even be added twice to the vtbl)
This assert triggers when compiling druntime with a debug compiler, namely with core.stdcpp.exception.