-
-
Notifications
You must be signed in to change notification settings - Fork 672
fix issue 20042 - __vector CTFE crashes the compiler #10160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10160" |
|
This solution is fine by me; thanks for working on this. Please have a look at issue 20041, as well - its symptom is even worse, but I suspect it has the same root cause. If this PR can fix both, a separate test case should be added for 20041, since its symptom is different. |
|
The other issue is a 2.085 regression. This one crashed since much longer. |
ibuclaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to change formatting here.
fix issue 20042 - __vector CTFE crashes the compiler merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This fix prevents the crash and a proper error message is issued, but doesn't add the code to accept the assign from slice to vector. This means that if this PR gets accepted then the issue would have to be reopened and converted to "enhancement".