Skip to content

fix issue 20045 - bogus error: "integer constant expression expected instead of (uint).sizeof#10174

Merged
dlang-bot merged 1 commit intostablefrom
unknown repository
Jul 15, 2019
Merged

fix issue 20045 - bogus error: "integer constant expression expected instead of (uint).sizeof#10174
dlang-bot merged 1 commit intostablefrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 14, 2019

Bug caused because TypeSArray.dim semantic was not done but required when the compiler wanted to mangle it.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20045 normal bogus error: "integer constant expression expected instead of (uint).sizeof"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10174"

@ghost ghost closed this Jul 14, 2019
@ghost ghost reopened this Jul 14, 2019
@ghost
Copy link
Author

ghost commented Jul 14, 2019

So far the only solution found is to resolve the type twice if the alias contains STCs. Maybe there's a better one so don't merge, even if green.

@ghost
Copy link
Author

ghost commented Jul 14, 2019

The fix is good now. Something similar to what is added already existed for the assoc arrays.

@dlang-bot dlang-bot merged commit 4f34502 into dlang:stable Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants