Fix issue 20052 - SIMD 32 bytes segfault#10178
Merged
dlang-bot merged 3 commits intodlang:stablefrom Jul 15, 2019
Merged
Conversation
c47fd0c to
f485d1a
Compare
ghost
approved these changes
Jul 15, 2019
thewilsonator
approved these changes
Jul 15, 2019
wilzbach
pushed a commit
to wilzbach/dmd
that referenced
this pull request
Jul 30, 2019
Fix issue 20052 - SIMD 32 bytes segfault merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue 20052.
When doing runtime stack alignment, the stack frame must be saved otherwise the return address will be lost.
For example:
the following function
generated the following instructions:
Notice there is no
RBP. When the return procedure is reached, theretinstruction pops the return address from the stack which has been altered earlier by the alignment instruction, which crashes the program.This patch does two things: 1) make sure
BPis stored, and a properleaveprocedure is used whenever there is runtime stack alignent. 2) omit runtime alignment when all symbols are dead.