Skip to content

split cdd_u64 into two functions to avoid long optimization times#10240

Merged
PetarKirov merged 1 commit intodlang:masterfrom
rainers:longopt_cdd_u64
Jul 29, 2019
Merged

split cdd_u64 into two functions to avoid long optimization times#10240
PetarKirov merged 1 commit intodlang:masterfrom
rainers:longopt_cdd_u64

Conversation

@rainers
Copy link
Member

@rainers rainers commented Jul 29, 2019

This function takes more than 10 seconds on my system in the optimizer, but was the only function that takes more than 2 seconds.

Splitting it into two functions moves them somewhere into the 1-2 second interval. There are a about a dozen other functions that need similar time to optimize.

This is trying to recover reproducible builds, see #10238 (comment)

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10240"

@PetarKirov PetarKirov merged commit 0411f41 into dlang:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants