Skip to content

Conversation

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10241"

@JinShil
Copy link
Contributor Author

JinShil commented Jul 30, 2019

See also dlang/druntime#2704 (review)

@rainers
Copy link
Member

rainers commented Jul 30, 2019

I think this should not be necessary, see dlang/druntime#2706 (comment)

@JinShil
Copy link
Contributor Author

JinShil commented Jul 30, 2019

Closing. There are some const-ness problems in the GC interface and implementations, but fixing that will have to be a different PR.

@JinShil JinShil closed this Jul 30, 2019
@JinShil JinShil deleted the fix_rmem branch July 30, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants