azure: add OMF build with LATEST dmd#10253
Conversation
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10253" |
| else | ||
| export MODEL_FLAG="-m32" | ||
| MAKE_FILE="win32.mak" | ||
| LIBNAME=phobos.lib |
There was a problem hiding this comment.
| LIBNAME=phobos.lib | |
| LIBNAME=phobos32.lib |
There was a problem hiding this comment.
phobos.lib is the name of the OMF library so far. That's why I had to special case it.
|
Do we have more free jobs on Azure? Testing a debug build would be nice, too. |
|
Yes we have 10x parallelism (: |
|
Open-source projects have unlimited free jobs and up to 10 of them can execute in parallel ;) |
…lready existing, simplify space handling
Thanks, good to know. I've restored the quotes and repaired the 64-bit build (it didn't do anything after my change). |
|
To address the failure on azure, you'll probably need to add quotes around the |
Yeah, noticed that, too. Added now while trying to make sure no double quoting happens. |
| /// add quotes around the whole string if it contains spaces that are not in quotes | ||
| string quoteSpaces(string str) | ||
| { | ||
| if (str.indexOf(' ') < 0) |
There was a problem hiding this comment.
Would this smaller version work?
if (str.startsWith(`"`) || str.indexOf(' ') < 0)
return str;
return `"` ~ str ~ `"`;There was a problem hiding this comment.
Not with the current default:
Line 634 in edc9b35
There was a problem hiding this comment.
Jesus BATCH is friggin weird
There was a problem hiding this comment.
If you want it to also handles spaces on posix systems, you'll probably need a different implementation for posix. But not a big deal since there's probably alot of other stuff that wouldn't work with the DMD build if there were spaces in the path.
There was a problem hiding this comment.
If you want it to also handles spaces on posix systems, you'll probably need a different implementation for posix. But not a big deal since there's probably alot of other stuff that wouldn't work with the DMD build if there were spaces in the path.
I also wouldn't expect spaces in filenames on posix to be battle tested. It's also quite a mess dealing with them between bash, make and every other tool.
Also: