Skip to content

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 28, 2019

I believe I made a mistake in #9068

If a public import does not contain a DDoc comment, I still emitted it to the documentation file, just without the comment. I tested other symbols, and it appears that when a DDoc comment is absent, the symbol is not emitted to the documentation file. This PR makes the public imports work the same way.

I think this is the correct behavior, but if I'm mistaken, please let me know.

cc @thewilsonator @ZombineDev

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10365"

@PetarKirov
Copy link
Member

PetarKirov commented Aug 28, 2019

Can you add a test for that? Otherwise LGTM.

@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2019

Can you add a test for that?

Done. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants