Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code#10547
Merged
thewilsonator merged 1 commit intodlang:stablefrom Nov 8, 2019
Merged
Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code#10547thewilsonator merged 1 commit intodlang:stablefrom
thewilsonator merged 1 commit intodlang:stablefrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10547" |
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 7, 2019
Index is not decremented which causes bounds checking error.
8027233 to
5ed5704
Compare
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 7, 2019
Index is not decremented which causes bounds checking error.
thewilsonator
approved these changes
Nov 7, 2019
Contributor
|
please target stable |
Member
Author
|
Sure. |
5ed5704 to
450c957
Compare
Member
Author
|
Done. |
Index is not decremented which causes bounds checking error.
Contributor
|
Auto-merge toggled on |
Member
Author
|
Thanks. |
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 12, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 15, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 20, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane
added a commit
to SSoulaimane/dmd
that referenced
this pull request
Nov 20, 2019
Index is not decremented which causes bounds checking error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index is not decremented which causes bounds checking error.