dmd.toir: Merge 32 and 64bit intrinsic arrays#10655
Closed
ibuclaw wants to merge 1 commit intodlang:masterfrom
Closed
dmd.toir: Merge 32 and 64bit intrinsic arrays#10655ibuclaw wants to merge 1 commit intodlang:masterfrom
ibuclaw wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10655" |
ibuclaw
force-pushed
the
intrinsicops
branch
from
2561b40 to
f5fabe2
Compare
rainers
reviewed
Dec 10, 2019
ibuclaw
force-pushed
the
intrinsicops
branch
from
f5fabe2 to
7a3ae31
Compare
Member
Author
|
Looks like @thewilsonator had a better idea in #10656. :-o |
rainers
reviewed
Dec 11, 2019
| "4math6rndtolFNaNbNiNfeZl", | ||
| "4math6yl2xp1FNaNbNiNfeeZe", | ||
| ]; | ||
| __gshared immutable(char)*[11] std_namearray; |
Member
There was a problem hiding this comment.
No need for runtime initialization here, just use static immutable.
rainers
reviewed
Dec 11, 2019
| __gshared immutable(char)*[62] core_namearray; | ||
| if (init_guard < 2) | ||
| { | ||
| core_namearray = [ |
Member
There was a problem hiding this comment.
I think this assignment will cause the an allocation of the array literal. Happens only once, but maybe better to just use static initialization and then patching the 4 entries?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for the intrinsic names, there's only 4 places where they differ between the two.