Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw: use runtime from VC 12 (VS 2012) for better C99 support #10799

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

rainers
Copy link
Member

@rainers rainers commented Feb 18, 2020

Since dlang/installer#346, the mingw runtime can be combined with any MS C runtime from VC8 to VC12.

With dlang/installer#436, the necessary redistributable DLLs will be part of the dmd distribution, so no additional installers necessary.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10799"

@rainers
Copy link
Member Author

rainers commented Feb 18, 2020

Unfortunately, we don't have any test for the mingw libraries based builds. Even if there were some using the mingw libs of the host compiler, this update would need a library not yet in any dmd release.

@Geod24
Copy link
Member

Geod24 commented Feb 18, 2020

Does this warrant a changelog entry ?

@rainers
Copy link
Member Author

rainers commented Feb 18, 2020

Does this warrant a changelog entry ?

I will create one for all the recent changes to the Windows installation, probably in the installer repository.

@dlang-bot dlang-bot merged commit bc6e2a9 into dlang:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants