fix Issue 19959 - Eponymous template FQN's re-state the template name#10846
Open
rainers wants to merge 1 commit intodlang:masterfrom
Open
fix Issue 19959 - Eponymous template FQN's re-state the template name#10846rainers wants to merge 1 commit intodlang:masterfrom
rainers wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @rainers! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#10846" |
RazvanN7
reviewed
Mar 2, 2020
| if (Dsymbol.oneMembers(ti.members, &sym, ident) && sym is p) | ||
| continue; | ||
|
|
||
| if (auto td = pparent.isTemplateDeclaration()) |
Contributor
There was a problem hiding this comment.
Since the logic is duplicated, I suggest moving the check in a function that receives a ScopeDsymbol (or a template function that receives a template instance or a template declaration) so that we save some lines of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 caveats: