Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of obsolete __ArrayEq lowering #11212

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Get rid of obsolete __ArrayEq lowering #11212

merged 1 commit into from
Jun 23, 2020

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jun 2, 2020

Checking arrays of different element types for equality is handled by the (more recent) __equals() lowering, rendering __ArrayEq obsolete and enabling to get rid of duplicated functionality in druntime, see: https://github.com/dlang/druntime/blob/9ce4a36f1f4edb73683775e5824272da9e27dccc/src/core/internal/array/equality.d#L56-L65

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11212"

@kinke kinke marked this pull request as draft June 2, 2020 20:32
@thewilsonator
Copy link
Contributor

This looks good, is it still draft?

@kinke
Copy link
Contributor Author

kinke commented Jun 3, 2020

I thought it'd be a trivial little change, but it turned out more involved and probably need some more analysis. I might also look into the different-floating-points => creal conversion, one of the surprises of the surrounding code.

@kinke
Get rid of obsolete __ArrayEq lowering
f09ba83 
Comparing arrays of different element types for equality is (also)
handled by the (more recent) __equals() lowering, rendering __ArrayEq
obsolete and enabling to get rid of duplicated functionality in
druntime too, see:
https://github.com/dlang/druntime/blob/master/src/core/internal/array/equality.d
@kinke kinke marked this pull request as ready for review June 20, 2020 03:10
@kinke kinke requested a review from ibuclaw as a code owner June 20, 2020 03:10
@ibuclaw
Copy link
Member

ibuclaw commented Jun 20, 2020 •
edited
Loading

I thought it'd be a trivial little change, but it turned out more involved and probably need some more analysis. I might also look into the different-floating-points => creal conversion, one of the surprises of the surrounding code.

It might be about time to put creal on a proper deprecation path.

@wilzbach
Copy link
Member

It might be about time to put creal on a proper deprecation path.

... #7640

kinke added a commit to kinke/druntime that referenced this pull request Jun 22, 2020
@kinke
Get rid of __ArrayEq
b086fe8 
As rendered obsolete by dlang/dmd#11212.
@kinke kinke mentioned this pull request Jun 22, 2020
Merged
@dlang-bot dlang-bot merged commit efcbf9a into dlang:master Jun 23, 2020
@kinke kinke deleted the __arrayeq branch June 23, 2020 08:29
kinke added a commit to kinke/druntime that referenced this pull request Jun 27, 2020
@kinke
Get rid of __ArrayEq
e125d3c 
As rendered obsolete by dlang/dmd#11212.
@MoonlightSentinel
Copy link
Contributor

This PR apparently fixed https://issues.dlang.org/show_bug.cgi?id=21012 along the way.

n8sh added a commit to n8sh/druntime that referenced this pull request Jul 8, 2020
@n8sh
Fix Issue 21029 - Remove __ArrayEq which the compiler no longer uses …
d0f1e7a 
…as of dlang/dmd#11212
dlang-bot pushed a commit to dlang/druntime that referenced this pull request Jul 8, 2020
@n8sh @dlang-bot
Fix Issue 21029 - Remove __ArrayEq which the compiler no longer uses …
54197db 
…as of dlang/dmd#11212
kinke added a commit to kinke/druntime that referenced this pull request Jul 8, 2020
@kinke
Get rid of __ArrayEq
d0572ee 
As rendered obsolete by dlang/dmd#11212.
@kinke kinke mentioned this pull request Sep 29, 2020
Closed
@RazvanN7 RazvanN7 mentioned this pull request Feb 8, 2023
Merged
@RazvanN7 RazvanN7 mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Merge:auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kinke @dlang-bot @thewilsonator @ibuclaw @wilzbach @MoonlightSentinel