Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for the invalid "lhs internal pointer" error #11267

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

Do a manual schwartzSort without using Tuple until all host
compilers have the fix implemented in dlang/phobos#7524.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11267"

Do a manual `schwartzSort` without using `Tuple` until all host
compilers have the fix implemented in dlang/phobos#7524.
@MoonlightSentinel MoonlightSentinel force-pushed the schwartzsort-workaround branch from 3eaea2d to ab0d07f Compare June 13, 2020 15:56
@ghost
Copy link

ghost commented Jun 14, 2020

can this be merged ? I have a PR affected by the problem fixed here.

@dlang-bot dlang-bot merged commit d263f80 into dlang:master Jun 15, 2020
@MoonlightSentinel MoonlightSentinel deleted the schwartzsort-workaround branch June 20, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants