Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer dtor attributes etc. before checks for (deprecated) DeleteExp #11854

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Oct 11, 2020

When a function hasn't had its attributes inferred yet, but is checked for being pure/safe/..., it is for some reason set as impure/non-safe, and a later semantic analysis doesn't infer them anymore...

E.g.:

dmd/src/dmd/func.d

Lines 1337 to 1338 in b6526df

if (flags & FUNCFLAG.purityInprocess)
setImpure();

dmd/src/dmd/func.d

Lines 1376 to 1381 in b6526df

if (flags & FUNCFLAG.purityInprocess)
{
flags &= ~FUNCFLAG.purityInprocess;
if (fes)
fes.func.setImpure();
}

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11854"

When a function hasn't had its attributes inferred yet, but is checked
for being pure/safe/..., it is for some reason set as impure/non-safe,
and a later semantic analysis doesn't infer them anymore...
@12345swordy
Copy link
Contributor

Should the dtor attributes be infer by default?

@RazvanN7 RazvanN7 merged commit b6ca893 into dlang:master Nov 4, 2020
@kinke kinke deleted the delete branch November 4, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants