Skip to content

Added location to ConditionalDeclaration and StaticIfDeclaration#11914

Merged
dlang-bot merged 1 commit intodlang:masterfrom
AsterMiha:CondCompLoc
Oct 30, 2020
Merged

Added location to ConditionalDeclaration and StaticIfDeclaration#11914
dlang-bot merged 1 commit intodlang:masterfrom
AsterMiha:CondCompLoc

Conversation

@AsterMiha
Copy link
Contributor

Continuing adding location to the remaining AST nodes

Since I chose to let the location of DVCondition start from the actual condition instead of the version and debug symbols[1], I set the location of ConditionalDeclaration to these symbols, as this is the node used for both VersionCondition and DebugCondition.

StaticIfCondition already starts at static so, at the moment, StaticIfDeclaration would have the exact same location. Should the location of StaticIfCondition be changed to only point to the condition?

[1] #11907

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @AsterMiha! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11914"

@AsterMiha AsterMiha force-pushed the CondCompLoc branch 2 times, most recently from 34f8852 to 2480476 Compare October 29, 2020 14:52
@thewilsonator
Copy link
Contributor

Rebase to fix build kite. Circle I have no idea.

@12345swordy
Copy link
Contributor

All green here.

@dlang-bot dlang-bot merged commit b35430e into dlang:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments