Added location to ConditionalDeclaration and StaticIfDeclaration#11914
Merged
dlang-bot merged 1 commit intodlang:masterfrom Oct 30, 2020
Merged
Added location to ConditionalDeclaration and StaticIfDeclaration#11914dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @AsterMiha! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11914" |
34f8852 to
2480476
Compare
Contributor
|
Rebase to fix build kite. Circle I have no idea. |
2480476 to
b9bd526
Compare
Contributor
|
All green here. |
thewilsonator
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing adding location to the remaining AST nodes
Since I chose to let the location of DVCondition start from the actual condition instead of the
versionanddebugsymbols[1], I set the location of ConditionalDeclaration to these symbols, as this is the node used for both VersionCondition and DebugCondition.StaticIfCondition already starts at
staticso, at the moment, StaticIfDeclaration would have the exact same location. Should the location of StaticIfCondition be changed to only point to the condition?[1] #11907